Download file from get requst node js

Show 3 more comments. MikeL 5, 38 38 silver badges 41 41 bronze badges. Augusto Roman Augusto Roman 6 6 silver badges 4 4 bronze badges.

What for are you storing request into a variable? You are right, there is no need to save the request, its not used anyway. That's what you mean? Yes, I think that's what polkovnikov. Per default the fs. Bjarke Pjedsted Bjarke Pjedsted 4 4 silver badges 8 8 bronze badges.

Two comments on this: 1 it should probably reject Error objects, not strings, 2 fs. This works great! No errors popped up but the. Removing the logic for the flag fixed it. Just wanted to point that out if someone had the issues with the approach. Is there a memory leak in this answer: stackoverflow. You can add timeout like I did in http. The memory leak is only if the file take too long to be downloaded. Based on the other answers above and some subtle issues, here is my attempt.

Check the file does not exist before hitting the network by using fs. Only create the fs. This reduces the amount of fs. Even on a OK we can still possibly reject due to an EEXIST file already exists imagine another process created the file whilst we were doing network calls.

Recursively call download if you get a Moved Permanently or Found Moved Temporarily redirect following the link location provided in the header. The issue with some of the other answers recursively calling download was that they called resolve download instead of download This way the nested chain of promises resolve in the correct order.

It might seem cool to clean up the temp file asynchronously, but I chose to reject only after that completed too so I know that everything start to finish is done when this promise resolves or rejects. Josh Peak Josh Peak 4, 4 4 gold badges 33 33 silver badges 48 48 bronze badges. You shouldn't waste resources doing the download if the destination file already exists. Do the check first if possible. Phil Really good point. I have updated the example with an earlier guard check before falling into the recursive networking calls but left the success file handling code the same.

This short circuit guard statement should save some time in this case now. JoshPeak what if the file is updated on server. This solution is only checking the name of the resource. If the file is different on the server then comparing modifed timestamps and hashes of content would be required conditions to invalidate the local cache. Correct cache invalidation is beyond the scope of this question and warrants it's own question and depends how servers implement HTTP ETag protocols.

Vince Yuan's code is great but it seems to be something wrong. But we don't check the result if callback callback err. Feel Physics Feel Physics 2, 4 4 gold badges 23 23 silver badges 36 36 bronze badges. I prefer request because you can use both http and https with it.

Looks like Request has been deprecated github. No new changes are expected to land. Post as a guest Name. Email Required, but never shown. The Overflow Blog. Podcast An oral history of Stack Overflow — told by its founding team. Millinery on the Stack: Join us for Winter Summer? Bash, ! Featured on Meta. New responsive Activity page. Linked Related You could pass both variables as function parameters to create a more general download method.

This signals a successful data transmission. At this point, resolve the promise to complete the file transfer. To recognize error situations, listen for the error event as well. The readable stream might signal the error event in situations like the underlying data flow interrupted. Handle this scenario as well. It is pretty straight forward and the logic would be that the promise will resolve itself once the finish callback is fired and we are rejecting when it fires an error callback.

What is GZIP? So if you are not enabling GZIP in the request options then the actual response from the server that you will get is compressed gibberish that will result in a corrupt file.

Also make sure the headers that you are setting are correct and they are in sync with what a normal request to that file would look like.